Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Rework theming system, add new theme. #789

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Conversation

bastienwirtz
Copy link
Owner

@bastienwirtz bastienwirtz commented Jun 26, 2024

Description

Rework the style organization to make possible to define colors using CSS variable (instead of only in the yaml configuration), making possible to . Also leverage css @layer to make it easier to override styles in theme or custom CSS stylesheet.

Added features:

  • Customize colors using CSS variables
  • Add custom css classes on a item groups.
  • Finally integrate @walkxcode great theme!

Fixes #305 #398 #406

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

It might break some theming customization, but it should be minimal.

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for homer-demo-content ready!

Name Link
🔨 Latest commit 529fa64
😎 Deploy Preview https://deploy-preview-789--homer-demo.netlify.app

@walkxcode
Copy link

🥳

docs/configuration.md Outdated Show resolved Hide resolved
@bastienwirtz bastienwirtz marked this pull request as ready for review June 28, 2024 17:17
@bastienwirtz bastienwirtz merged commit 359f1ff into main Jun 29, 2024
5 checks passed
@bastienwirtz bastienwirtz deleted the theming-rework branch June 29, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New built-in theme
3 participants