Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version handler for api #25

Merged
merged 2 commits into from
May 30, 2024
Merged

Add version handler for api #25

merged 2 commits into from
May 30, 2024

Conversation

danyalprout
Copy link
Collaborator

Description

This adds support for the consensus layer version api to the blob archiver api.

Building the docker images (or via the makefile), will pull in the current head commit hash as the version.

❯ curl -s 0.0.0.0:8000/eth/v1/node/version | jq
{
  "data": {
    "version": "Blob Archiver API/39cf8e7c53901b2bb493b5a0dc003a1264da4de7"
  }
}

Copy link
Collaborator

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Might take the opportunity to bump op-monorepo and op-geth dependencies.

api/version/version.go Outdated Show resolved Hide resolved
@danyalprout danyalprout marked this pull request as ready for review May 30, 2024 15:53
@cb-heimdall
Copy link
Collaborator

Review Error for sebastianst @ 2024-05-30 16:42:48 UTC
User must have write permissions to review

@danyalprout danyalprout merged commit 42bd2a1 into master May 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants