Feature/erc20 integration #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@davidp94 really cool. Let me know when you want review ;-) |
|
I think it is ready to review - I need to test myself but can't find time right now. |
|
This looks really good @davidp94 see my comments ;) |
davidp94
commented
Jul 17, 2018
| @@ -27,35 +40,38 @@ contract Miximus is MerkelTree { | |||
| uint[2] c_p, | |||
| uint[2] h, | |||
| uint[2] k, | |||
| uint[] input | |||
| uint[] input, | |||
There was a problem hiding this comment.
@barryWhiteHat should we document what are the different inputs?
…us into feature/erc20_integration
Change insert and getUniqueLeaf function calls parameters.
|
Just ran the test and it works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs: