-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master #2
Open
phoenixiguess
wants to merge
163
commits into
baronapp:master
Choose a base branch
from
expo:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Master #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bartosz Kaszubowski <[email protected]>
# Why Adds missing changelog entries
…ission on Android (#15760) # Why Some apps only need coarse location. Only apps that need fine location need both enabled (coarse and fine). # How My app only needs coarse location so I wanted to remove the extra uneeded permission of fine location. But expo code is forcing fine location. Related discussion - https://forums.expo.dev/t/only-access-coarse-location-not-working-for-lowest-accuracy-location/57837 # Test Plan Existing test plan should work. # Checklist - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] This diff will work correctly for `expo build` (eg: updated `@expo/xdl`). - [x] This diff will work correctly for `expo prebuild` & EAS Build (eg: updated a module plugin).
…15633) # Why In order to make background location more felxible we should give a choice to developers whether or not the foreground service should be killed when the app is killed . i personally found this a show stopper . i for example have a cab booking system where i must show the driver that i'm using his location even when he kills his app . Following this PR #11775 i was able to make this optional . # How I've added a boolean option "killServiceOnDestroy" to LocationTaskServiceOptions which will be passed to the LocationTaskService Intent through extra params , if it's true the foreground service will dissapear on app killing . # Test Plan Try starting background location and killing the app from the task manager. if killServiceOnDestroy is true The notification should be destroyed , otherwise it'll stick .
…egateSubscriber (#15684) * Invoke super methods in the AppDelegate.m to support ExpoAppDelegateSubscriber * Update AppDelegate.m
…#15748) # Why fix the root cause of #15298 some context in the message: #15298 (comment) # How should only destroy the `ReactInstanceManager` if it does not bind with an Activity. # Test Plan follow steps from #15298 (comment)
…15773) # Why fix umbrella header not found from `use_frameworks!` because framework files will be copied into DerivedData folder and the folder structure is different to CocoaPods header folders. fix #15749 # How instead of using custom modulemap with the `umbrella directory '../../Public/React-Core/React'`. this change further patch CocoaPods to generate umbrella header and modulemap file together with the public header files. # Test Plan - bare-expo ci passed - ``` expo init sdk44 # select bare yarn add file:/path/to/expo/expo/packages/expo-modules-autolinking add `use_frameworks!` in `ios/Podfile` expo run:ios ```
* Added declarationMap to base tsconfig * et cp -a --no-lint --no-test --no-uniformity-check
… fix unit tests (#15779)
* [dev-launcher] add dev sessions and update deep link modal
Fix the "security documentation" link so that it no longer 404s.
Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.23 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.1.23...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…6011) Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.30 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.1.30...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.30 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.1.30...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.1 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/main/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.6.1...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [docs] EAS Build: update infra docs - macOS Monterey image * address PR feedback
* Fix -v flag * Fix bin Update index-test.ts Update index-test.ts Update index-test.ts
* [docs] add types and fix mdx link rewrite on windows * [docs] use regex replace instead replace all to support node 14
* [docs] add `prebuildCommand` to eas.json schema * docs: rephrase Co-authored-by: Dominik Sokal <[email protected]> * docs: additional info on prebuildCommand * docs: fix relative path to prebuild docs Co-authored-by: Dominik Sokal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
Test Plan
Checklist
expo build
(eg: updated@expo/xdl
).expo prebuild
& EAS Build (eg: updated a module plugin).