Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csv data module to the distribution #5528

Closed

Conversation

SasinduDilshara
Copy link
Contributor

Add csv data module to the distribution

ballerina-platform/module-ballerina-data.csv#4 will contains the more details about CSV data module.

Copy link

sonarcloud bot commented Aug 1, 2024

@@ -55,6 +55,7 @@ stdlibMqttVersion=1.1.1
stdlibOAuth2Version=2.11.0
stdlibTomlVersion=0.5.1
stdlibYamlVersion=0.5.3
stdlibDataCsvVersion=0.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we use a timestamped version here and check whether the build is passing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 1546f36

@SasinduDilshara SasinduDilshara marked this pull request as draft August 1, 2024 06:16
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Aug 16, 2024
@ThisaruGuruge
Copy link
Member

Aren't we releasing this with the Update 10 distribution?

@SasinduDilshara SasinduDilshara marked this pull request as ready for review November 20, 2024 06:00
Copy link

sonarcloud bot commented Nov 20, 2024

@SasinduDilshara
Copy link
Contributor Author

Aren't we releasing this with the Update 10 distribution?

We are planned to release 0.1.0 into the Ballerina central and release this with U11.

@SasinduDilshara
Copy link
Contributor Author

This PR will be wait until data.csv module migrate into java21.

RDPerera
RDPerera previously approved these changes Nov 25, 2024
Copy link
Member

@RDPerera RDPerera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SasinduDilshara
Copy link
Contributor Author

Updated the PR with lateset version

@SasinduDilshara
Copy link
Contributor Author

Updated the PR with lateset version

There is a build failure in the PR

Bir missing for package :ballerina/data.csv
Jar missing for package :ballerina/data.csv

I will check on this

Copy link

sonarcloud bot commented Nov 26, 2024

@SasinduDilshara
Copy link
Contributor Author

Updated the PR with lateset version

There is a build failure in the PR

Bir missing for package :ballerina/data.csv
Jar missing for package :ballerina/data.csv

I will check on this

Had a offline chat with team and decide to wait until newer minor version releases of the other modules

@SasinduDilshara
Copy link
Contributor Author

Updated the PR with lateset version

There is a build failure in the PR

Bir missing for package :ballerina/data.csv
Jar missing for package :ballerina/data.csv

I will check on this

Had a offline chat with team and decide to wait until newer minor version releases of the other modules

close the PR for now and will reopen once all the modules are updated in the distribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants