Give the build job a unique name with the machine and environment

[klutchell]

This allows us to mark specific build-only jobs as required.

Specifically for cases where tests are defined, but those tests may not be marked as required for an ESR branch to merge, so marking 'Yocto / All jobs' as required for that device is not ideal.

Change-type: patch

[rcooke-warwick]

To check I understand right, this is for the case where we have something in a device repo that has tests defined, but we're not deploying finalised ESR releases for - for example:

• some of the balena-raspberrypi repo device types: raspberrypi0-2w
• generic-amd64-fs in balena-generic

But on an ESR branch, these aren't required - so a PR might merge without tests passing for these device types - but if that happens then a finalised ESR release won't be deployed, only a draft - isn't that what we want?

What would be worse was if tests DID pass, because then an ESR release would be deployed for a DT we don't guarantee ESR support for? This is why we commented out the ESR regexp on the branch checks for non ESR devices isn't it - there will be no yocto / all jobs at all for them?, e.g: https://github.com/balena-os/balena-intel/blob/master/.github/workflows/surface-pro-6.yml#L11 If we offered ESR for all tested devices this doesn't matter of course.

[klutchell]

I think you're right @rcooke-warwick and we don't need this change.

For non-ESR devices nothing will run, build or tests, because the trigger is not enabled for that device type. There is nothing to be gained by allowing a "build only" requirement for devices.

This change on it's own wouldn't impact behaviour in any way, since all it does is add the machine and environment to the build step name. Might still be nice to have though? It's not a bad thing.