Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: Add GHA Built Test Deploy workflows #442

Merged
merged 1 commit into from
Oct 2, 2024
Merged

patch: Add GHA Built Test Deploy workflows #442

merged 1 commit into from
Oct 2, 2024

Conversation

rcooke-warwick
Copy link
Contributor

@rcooke-warwick rcooke-warwick commented Sep 19, 2024 •
edited
Loading

Adds build deploy test workflow

  • Create PR with all devices supported in the balena- multi-job in Jenkins
  • Set deploy environment to balena-cloud.com
  • Disable the associated multi-job and device jobs in Jenkins here
  • All required devices are passing on GHA + doesn't require a rebase
  • Approved by the reviewer (policy-bot passed)
  • Update branch protection to require the GHA workflows (https://github.com/balena-os/.github/pull/88)
  • Remove Jenkins build and deploy workflow (this PR)

reminders:

@flowzone-app flowzone-app bot enabled auto-merge September 19, 2024 09:08
@rcooke-warwick
patch: Add GHA Built Test Deploy workflows
3451453 
Changelog-entry:  Add GHA Built Test Deploy workflows
Signed-off-by: Ryan Cooke <[email protected]>
klutchell
klutchell reviewed Oct 1, 2024
View reviewed changes
.github/workflows/rockpi-4b-rk3399.yml
"test_suite": ["os","cloud","hup"],
"environment": ["bm.balena-dev.com"],
"runs_on": [["ubuntu-latest"]]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start being explicit about the worker_type property rather than relying on the defaults.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have the comments to say that it defaults to "testbot" and it avoids us having to mass change these files on device repos

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what scenario would we need to mass change the worker type though?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name change e.g testbot > autokit

But yeah, other than that unlikely.

klutchell
klutchell reviewed Oct 1, 2024
View reviewed changes
.github/workflows/rockpi-4b-rk3399.yml
# Allow manual workflow runs to force finalize without checking previous test runs
force-finalize: ${{ inputs.force-finalize || false }}
# Default to balena-staging.com for workflow dispatch, but balena-cloud.com for other events
deploy-environment: ${{ inputs.deploy-environment || 'balena-cloud.com' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newlines at the end of files is preferred (NIT)

@flowzone-app flowzone-app bot merged commit 86727be into master Oct 2, 2024
58 checks passed
@flowzone-app flowzone-app bot deleted the ryan/gha branch October 2, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vipulgupta2048 vipulgupta2048 vipulgupta2048 approved these changes

@klutchell klutchell Awaiting requested review from klutchell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcooke-warwick @klutchell @vipulgupta2048