Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add synonymous forms for reverse navigation on device and service to … #1854

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

otaviojacobi
Copy link
Contributor

…device service environment variable

Change-type: patch

@otaviojacobi otaviojacobi marked this pull request as ready for review November 20, 2024 15:52
@otaviojacobi otaviojacobi marked this pull request as draft November 20, 2024 16:32
auto-merge was automatically disabled November 20, 2024 16:32

Pull request was converted to draft

@otaviojacobi otaviojacobi requested a review from a team November 20, 2024 16:48
Copy link
Member

@thgreasi thgreasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect to also see the changes that use this in the same PR (since these are not exposed atm on a stable versioned endpoint) which also proves that the changes work, but I'm also fine w/ this PR as is 👍

src/balena.sbvr Show resolved Hide resolved
…device service environment variable

Change-type: patch
@thgreasi
Copy link
Member

go for it

@thgreasi
Copy link
Member

mmmmmmmerge it

@otaviojacobi otaviojacobi marked this pull request as ready for review November 22, 2024 17:42
@otaviojacobi otaviojacobi merged commit 1784132 into master Nov 22, 2024
53 checks passed
@otaviojacobi otaviojacobi deleted the add-synonymous-forms-for-dsev branch November 22, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants