Feature/add runtime configuration support for shairport / airplay #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A repository maintainer needs to approve this workflow run. https://github.com/balena-io-experimental/balena-sound/actions/runs/11543218872 Maintainers, please review all commits and react with 👍 to approve or 👎 to reject. Things to look for: GitHub Actions Security Cheat Sheet |
fabienheureux
force-pushed
the
feature/add-runtime-configuration-support-for-shairport
branch
from
5dd8578
to
7160b71
Compare
fabienheureux
commented
Oct 27, 2024
fabienheureux
commented
Oct 27, 2024
|
A repository maintainer needs to approve this workflow run. https://github.com/balena-io-experimental/balena-sound/actions/runs/11543378463 Maintainers, please review all commits and react with 👍 to approve or 👎 to reject. Things to look for: GitHub Actions Security Cheat Sheet |
fabienheureux
changed the title
|
@vipulgupta2048 any chance you could get a look at that PR ? |
|
@vipulgupta2048 do you think you could take a look at this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for configuring Shairport through Balena environment variable.
I needed to customize the latency on a device, this is now possible by using a environment variable
Many other configuration options could be taken from https://github.com/mikebrady/shairport-sync/blob/master/scripts/shairport-sync.conf.
I run this version on my fleet at the moment without issues :)
TODO