bump airplay2 version #668
Conversation
fabienheureux
force-pushed
the
feature/upgrade-airplay-2-implementation
branch
from
1928ade
to
58d507f
Compare
|
A repository maintainer needs to approve this workflow run. https://github.com/balena-io-experimental/balena-sound/actions/runs/11531725105 Maintainers, please review all commits and react with 👍 to approve or 👎 to reject. Things to look for: GitHub Actions Security Cheat Sheet |
|
@vipulgupta2048 any chance you could approve this PR ? I had to update the build step as it was failing for me. |
plugins/airplay/Dockerfile.template
Outdated
| RUN apk upgrade --no-cache && apk add --no-cache supervisor curl | ||
| RUN curl -skL https://raw.githubusercontent.com/balena-io-experimental/audio/master/scripts/alsa-bridge/alpine-setup.sh | sh | ||
| RUN apk del curl |
There was a problem hiding this comment.
| RUN apk upgrade --no-cache && apk add --no-cache supervisor curl | |
| RUN curl -skL https://raw.githubusercontent.com/balena-io-experimental/audio/master/scripts/alsa-bridge/alpine-setup.sh | sh | |
| RUN apk del curl | |
| RUN apk upgrade --no-cache && apk add --no-cache supervisor curl && \ | |
| curl -skL https://raw.githubusercontent.com/balena-io-experimental/audio/master/scripts/alsa-bridge/alpine-setup.sh | sh \ | |
| apk del curl |
Any reason why these steps can't happen together?
There was a problem hiding this comment.
I am not sure of the exact reason, but I had issues with building the airplay container without splitting these steps.
It was mostly trial and error...
I tried again with your suggestion and got the error below
Error: The command '/bin/sh -eo pipefail -c apk upgrade --no-cache && apk add --no-cache supervisor curl && curl -skL https://raw.githubusercontent.com/balena-io-experimental/audio/master/scripts/alsa-bridge/alpine-setup.sh | sh apk del curl' returned a non-zero code: 85
I tried again with
RUN apk upgrade --no-cache
RUN apk add --no-cache supervisor curl && \
curl -skL https://raw.githubusercontent.com/balena-io-experimental/audio/master/scripts/alsa-bridge/alpine-setup.sh | sh \
apk del curl
And got the error below
[Error] Some services failed to build:
[Error] Service: airplay
[Error] Error: The command '/bin/sh -eo pipefail -c apk add --no-cache supervisor curl && curl -skL https://raw.githubusercontent.com/balena-io-experimental/audio/master/scripts/alsa-bridge/alpine-setup.sh | sh apk del curl' returned a non-zero code: 2
Finally I tried with :
RUN apk upgrade --no-cache && apk add --no-cache supervisor curl && \
curl -skL https://raw.githubusercontent.com/balena-io-experimental/audio/master/scripts/alsa-bridge/alpine-setup.sh | sh
RUN apk del curl
And this worked...
There was a problem hiding this comment.
I just updated the branch
|
A repository maintainer needs to approve this workflow run. https://github.com/balena-io-experimental/balena-sound/actions/runs/11532141643 Maintainers, please review all commits and react with 👍 to approve or 👎 to reject. Things to look for: GitHub Actions Security Cheat Sheet |
|
A repository maintainer needs to approve this workflow run. https://github.com/balena-io-experimental/balena-sound/actions/runs/11532432755 Maintainers, please review all commits and react with 👍 to approve or 👎 to reject. Things to look for: GitHub Actions Security Cheat Sheet |
This upgrades Shairport version.
https://github.com/mikebrady/shairport-sync/releases