-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for the headless PlexAmp client #593
base: master
Are you sure you want to change the base?
Conversation
Added a container build for the headless PlexAmp client, this will allow a user to use the plex app on a mobile device to cast music from their media server to their Balena Sound device. Change-type: minor Signed-off-by: Lewis L. Foster <[email protected]>
An error occurred whilst building your landr site preview:
|
Change-Type: minor Signed-off-by: Lewis L. Foster <[email protected]>
@balena-ci retest |
really not sure why the generate version is failing, unless its just because its for an additional commit, could this be reviewed at some point though? |
Added a container build for the headless PlexAmp client, this will allow a user to use the plex app on a mobile device to cast music from their media server to their Balena Sound device. Change-type: minor Signed-off-by: Lewis L. Foster <[email protected]>
Change-Type: minor Signed-off-by: Lewis L. Foster <[email protected]>
I'll find a way to have it automatically pull the latest plexamp headless archive |
Using the versionbot/pr/593 branch I'm getting the following plex error in balena dashboard log:
The service then shuts down and enters a restart loop. I can't get a terminal open to investigate because it's in a constant shutdown/restart state. |
Fix: plexamp 4.6.0 requires Node 16 https://forums.plex.tv/t/plexamp-4-6-0-headless-install-error/821034 |
Ah didnt spot that, ill push up a change that bumps the node version |
One more thing you might want to look at is the login.sh. After a fresh build ** Otherwise everything is working great! Thank you for putting this together. I hope the balena-sound team merges this plugin. There are a lot of folks out there are looking for a player with spotify, airplay AND plex support. Right now --with this plugin-- this is the only player offering that combination. Additionally this would be the only player that allows plexamp multiroom streaming. |
A docker volume is used to persist the config data but it might be worth checking the file that stores the login state instead of just the directory |
…ather than the settings folder
That should be some docs about the plugin and using the user token config file instead of the settings folder |
@sniff122, great to see all these new interesting features. I am wondering how you would feel about adding the plugin as a Block on the Hub instead of including it directly in the repo here? That is what we designed the Blocks for, and then we can update the docs that allow people to add the block if they want the feature. It seems it would stop the app becoming heavier than it needs to be for those that don't use the feature. Would be interested to hear what you think. No problem continuing the development here though, just flagging that it may be difficult for us to merge it. |
Oh I didn't know about that, no clue how I didn't know, oh well. Sounds like it might be a better idea making it a block then |
Added a container build for the headless PlexAmp client, this will allow a user to use the plex app on a mobile device to cast music from their media server to their Balena Sound device.
Change-type: minor
Signed-off-by: Lewis L. Foster [email protected]
Hey there, appreciated contributor!
Have you taken a look at the contribution guidelines for this project? To enable our CI to work correctly and version the releases of the project, you need to ensure your commit messages contain the required information detailed here. Thank you!