Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test BasePoolFactory - 100% code coverage #771

Merged
merged 9 commits into from
Jul 16, 2024
Merged

Conversation

joaobrunoah
Copy link
Contributor

Description

This PR creates test to cover 100% of BasePoolFactory.sol.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Optimization: [ ] gas / [ ] bytecode
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

Closes #711

Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions.

pkg/pool-utils/test/foundry/BasePoolFactory.t.sol Outdated Show resolved Hide resolved
pkg/pool-utils/test/foundry/BasePoolFactory.t.sol Outdated Show resolved Hide resolved
pkg/pool-utils/test/foundry/BasePoolFactory.t.sol Outdated Show resolved Hide resolved
pkg/pool-utils/contracts/BasePoolFactory.sol Outdated Show resolved Hide resolved
pkg/pool-utils/contracts/BasePoolFactory.sol Outdated Show resolved Hide resolved
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything's addressed. Thanks!

@joaobrunoah joaobrunoah merged commit 70e66a7 into main Jul 16, 2024
12 checks passed
@joaobrunoah joaobrunoah deleted the test-base-pool-factory branch July 16, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage Report - Test BasePoolFactory.sol
2 participants