Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Fork Tests for Add/Remove Liquidity from Buffer #1090

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Create Fork Tests for Add/Remove Liquidity from Buffer #1090

wants to merge 8 commits into from
+103 −10

Conversation

joaobrunoah
Copy link
Contributor

Description

Create fork tests to make sure add and remove liquidity from buffer are not profitable to the user.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Optimization: [ ] gas / [ ] bytecode
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

EndymionJkb
EndymionJkb approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments.

pkg/vault/test/foundry/fork/ERC4626WrapperBase.t.sol Outdated Show resolved Hide resolved
pkg/vault/test/foundry/fork/ERC4626WrapperBase.t.sol Show resolved Hide resolved
pkg/vault/test/foundry/fork/ERC4626WrapperBase.t.sol Show resolved Hide resolved
pkg/vault/test/foundry/fork/ERC4626WrapperBase.t.sol Show resolved Hide resolved
pkg/vault/test/foundry/fork/ERC4626WrapperBase.t.sol Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EndymionJkb EndymionJkb EndymionJkb approved these changes

@jubeira jubeira Awaiting requested review from jubeira

@elshan-eth elshan-eth Awaiting requested review from elshan-eth

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joaobrunoah @EndymionJkb