Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BPT Price Fetch Error - Separating in chunk of 10, coingecko only allows 10 token prices per request now; #549

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

lgahdl
Copy link
Contributor

@lgahdl lgahdl commented Nov 28, 2023

Adding example for bptPrice;
Separating coingecko token prices requests by chunks of 10, coingecko is only allowing 10 tokens per request in the free plan, they have a paid plan for more token prices (https://www.coingecko.com/en/api/pricing);

Separating coingecko token prices requests by chunks of 10, coingecko is only allowing 10 tokens per request in the free plan, they have a paid plan for more token prices (https://www.coingecko.com/en/api/pricing);
@brunoguerios brunoguerios added the bug Something isn't working label Nov 29, 2023
@brunoguerios
Copy link
Member

There are some tests failing. Can you please double check?

@lgahdl lgahdl linked an issue Nov 29, 2023 that may be closed by this pull request
Luiz Gustavo Abou Hatem De Liz added 2 commits November 29, 2023 18:34
Skipping impermanent loss tests, the coingecko requests are above the free limit;
@lgahdl
Copy link
Contributor Author

lgahdl commented Nov 29, 2023

Hey @brunoguerios, I'm skipping the impermanent loss integration tests by now, they requests of two tests are above the rate limit of coingecko free plan, the full test suit is making more than 30 coingecko requests per minute, so I'm skipping these ones until we find a better approach, ok?
Obs.: Running only the impermanent loss tests, they're working, only with the full suit that these tests breaks :/

@brunoguerios
Copy link
Member

I think that's ok for now. 👍
Please create an issue, so we can keep track of that tech debt.
If I understood correctly, a solution would be to paginate the coingecko historical prices requests are well, right?
Anyway, I agree we can handle that in a future PR, since this bug is affecting the FE and should be fixed sooner rather than later.

@brunoguerios brunoguerios merged commit e1160d0 into develop Nov 30, 2023
3 checks passed
@brunoguerios brunoguerios deleted the bpt-price-error branch November 30, 2023 13:11
Copy link
Contributor

@gmbronco gmbronco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR. Debouncer class has a limit param, which executes when it's reached essentially splitting requests into buckets. All we need to do is to set it to 10 and none of the changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BETS/wstETH pool not returning bptPrice
3 participants