-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Price Impact - ABA - create POC to validate approach #545
Draft
brunoguerios
wants to merge
16
commits into
develop
Choose a base branch
from
price-impact-compare
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writes the token addresses, balances in pool, and relative proportion being added or swapped in each report. This puts each test in perspective to focus on practical scenarios. May need to roll back some changes in yarn and package. results2.csv can be written over or deleted.
Set of tests with printed CSVs for BAL/WETH and COIL/USDC in each direction of swaps, single side, and unbalanced deposits.
brunoguerios
changed the title
Add test cases for ABA price impact comparison
Price Impact - ABA - create POC to validate approach
Nov 23, 2023
Testing for sfrxeth/wsteth/reth, 80BAL/20WETH, 50COIL/50USDC, 35OATH/35GRAIN/15USDC/15WETH with each token in and different unbalanced circumstances. Pending a review of the results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.