Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tenderly default config #475

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Remove tenderly default config #475

merged 2 commits into from
Jul 5, 2023

Conversation

brunoguerios
Copy link
Member

This PR removes Tenderly default config and requires custom config to be provided when using Tenderly simulations on generalisedJoin/Exit.

@brunoguerios brunoguerios self-assigned this Jun 21, 2023
lgahdl
lgahdl approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@lgahdl lgahdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

johngrantuk
johngrantuk approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@johngrantuk johngrantuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying this up.

@johngrantuk johngrantuk merged commit 16f6b71 into develop Jul 5, 2023
@johngrantuk johngrantuk deleted the remove-tenderly-default-config branch July 5, 2023 08:45
@johngrantuk johngrantuk mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgahdl lgahdl lgahdl approved these changes

@johngrantuk johngrantuk johngrantuk approved these changes

@gmbronco gmbronco Awaiting requested review from gmbronco

Assignees

@brunoguerios brunoguerios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brunoguerios @johngrantuk @lgahdl