[1.x] add command to update locations tables #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaioken
changed the title
kaioken
requested changes
Sep 6, 2023
kaioken
requested changes
Sep 26, 2023
| switch ($table) { | ||
| case '1': | ||
| $countries = new UpdateCountriesAction(); | ||
| $countries->execute($app); |
There was a problem hiding this comment.
@tiberius19 pass the app at the constructor
| $table = $this->argument('tableNumber') ?? null; | ||
|
|
||
| switch ($table) { | ||
| case '1': |
There was a problem hiding this comment.
@tiberius19 use match so you can test how it works
| { | ||
| $appUid = $this->argument('app_uuid'); | ||
| $app = Apps::getByUuid($appUid); | ||
| $table = $this->argument('tableNumber') ?? null; |
There was a problem hiding this comment.
@tiberius19 instead of # use strings so users know what to use
config/locations.php
Outdated
| <?php | ||
|
|
||
| return [ | ||
| 'locationsUrl' => [ |
There was a problem hiding this comment.
@tiberius19 this is not needed right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.