Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contacts on update people #2662

Open
wants to merge 7 commits into
base: development
Choose a base branch
from
Open

Conversation

FredPeal
Copy link
Contributor

General Description

Please include a summary of the changes and the related issue. Highlight key points of the PR, any relevant information, and reasons for making the change.

Related Issue

A link to the ticket or issue that this PR is related to.(if applicable)

Checklist

A checklist of things that should be done before merging this PR. Linked to the ticket or issue that this PR is related to.(if applicable)

  • I have performed a self-review of my code.
  • I have added tests to cover my changes.
  • I have updated the documentation (if needed).
  • My changes generate no new warnings.
  • My changes do not break any existing tests.

Screenshots (if applicable)

Provide screenshots of impactful changes you have made so that the reviewer can quickly understand the changes.

@FredPeal FredPeal requested a review from kaioken December 13, 2024 21:00
@@ -15,6 +15,7 @@ public function __construct(
public readonly string $value,
public readonly int $contacts_types_id,
public readonly int $weight = 0,
public readonly ?string $id = null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FredPeal why string?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants