Merge pull request #1659 from bakaphp/hotfix-zoho-lead

Merge pull request #1655 from bakaphp/hotfix-zoho-lead
bakaphp · Jul 9, 2024 · 476b578 · 476b578
2 parents 8ea83d1 + c562813
commit 476b578
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/Domains/Connectors/Zoho/DataTransferObject/ZohoLead.php b/src/Domains/Connectors/Zoho/DataTransferObject/ZohoLead.php
@@ -59,8 +59,7 @@ public static function fromLead(Lead $lead): self
     public function toArray(): array
     {
         $data = parent::toArray();
-
-        unset($data['additionalFields']);
+        //unset($data['additionalFields']);
 
         return $data;
     }
@@ -96,7 +95,9 @@ protected static function mapProperties(array $map, array &$data, array $entity)
                 $value = $creditScore[(int) $value] ?? $value;
             }
 
-            $data[$name] = $value;
+            if ($value !== null) {
+                $data[$name] = $value;
+            }
         }
     }
 

diff --git a/src/Domains/Connectors/Zoho/Workflows/ZohoLeadActivity.php b/src/Domains/Connectors/Zoho/Workflows/ZohoLeadActivity.php
@@ -19,6 +19,9 @@
 use Webleit\ZohoCrmApi\Modules\Leads as ZohoLeadModule;
 use Workflow\Activity;
 
+/**
+ * @todo refactor move core logic to SyncLeadWithZohoAction
+ */
 class ZohoLeadActivity extends Activity implements WorkflowActivityInterface
 {
     use KanvasJobsTrait;