Merge pull request #859 from bakaphp/feat-variant-chanel-search

refact: variant channel filter
bakaphp · Jan 29, 2024 · 3224089 · 3224089
2 parents e5d8c1e + 5bf8b9c
commit 3224089
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/app/GraphQL/Inventory/Builders/Variants/VariantChannelBuilder.php b/app/GraphQL/Inventory/Builders/Variants/VariantChannelBuilder.php
@@ -59,10 +59,6 @@ public function allVariantsPublishedInChannelFilterByAttributes(
         $channelUuid = $args['id'];
         $attributes = $args['attributes'] ?? [];
 
-        if (empty($attributes)) {
-            // throw new ValidationException('Attributes as array is required');
-        }
-
         if (isset($attributes['price']) && ! is_array($attributes['price'])) {
             throw new ValidationException('Price must be an array');
         }

diff --git a/graphql/schemas/Inventory/variantChannel.graphql b/graphql/schemas/Inventory/variantChannel.graphql
@@ -107,7 +107,7 @@ extend type Query {
 
     channelVariantsFilterByAttributes(
         id: ID!
-        attributes: Mixed!
+        attributes: Mixed
         where: _ @whereConditions(columns: ["slug", "uuid", "name", "sku"])
         orderBy: _
             @orderBy(