refact: downlaod all leads

bakaphp · Jul 27, 2024 · 1b733ae · 1b733ae
1 parent 7720150
commit 1b733ae
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/Domains/Connectors/Zoho/Actions/DownloadAllZohoLeadAction.php b/src/Domains/Connectors/Zoho/Actions/DownloadAllZohoLeadAction.php
@@ -42,7 +42,7 @@ public function execute($totalPages = 50, $leadsPerPage = 200): Generator
                 }
 
                 $this->totalLeadsProcessed++;
-                yield $localLead->getId();
+                yield $localLead;
             }
         }
     }

diff --git a/tests/Connectors/Integration/Zoho/LeadTest.php b/tests/Connectors/Integration/Zoho/LeadTest.php
@@ -11,6 +11,7 @@
 use Kanvas\Guild\Enums\FlagEnum;
 use Kanvas\Guild\Leads\Actions\CreateLeadReceiverAction;
 use Kanvas\Guild\Leads\DataTransferObject\LeadReceiver;
+use Kanvas\Guild\Leads\Models\Lead;
 use Kanvas\Guild\Support\Setup;
 use Tests\TestCase;
 
@@ -50,6 +51,10 @@ public function testDownloadAllLeads(): void
 
         $leads = $downloadAllLeads->execute(totalPages: 1, leadsPerPage: 1);
 
+        foreach ($leads as $lead) {
+            $this->assertInstanceOf(Lead::class, $lead);
+        }
+
         $this->assertIsArray(iterator_to_array($leads));
         $this->assertEquals(1, $downloadAllLeads->getTotalLeadsProcessed());
     }