Game event update #1030
Merged
Game event update #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Back to World Fixed Headers Added Re-directs to proper pages Added values to annouce with description Added Database values
Fixed the headers
Corrected headers Fixed re-directs
|
Ready to be reviewed. |
|
Thanks for the PR! I'm not sure about copying the database table content into the wiki page - it's apparently going to get out of date and usually only the table structure is beeing described here. |
|
I think every page should have their database or dbc information, how many times you wanted to check an information quickly on something but you're not not at the pc as example to no see some dbc data or some database data (this is one sure you can see the github but may be hard to see it :v) |
Kitzunu
requested changes
Nov 24, 2024
docs/game_event.md
Outdated
| | 1 | Announce the description of the Event to the world | | ||
| | 2 | Use the `event.announce` settings from the config | | ||
|
|
||
| ### Database Content |
There was a problem hiding this comment.
delete this. The database isnt static and updating this everytime something changes is just bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
game_eventgame_event_quest_conditiongame_event_conditionUpdate headers, fixed re-directs, added Database to
game_eventRelated Issue
Closes
Thank you for contributing to the AzerothCore wiki.
Remember that the wiki is currently available in English and Spanish.