Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: ItemExtendedCost.dbc and ItemPurchaseGroup.dbc, Updated npc_vendor#extendedcost #1017

Merged
merged 13 commits into from
Nov 28, 2024

Conversation

TheSCREWEDSoftware
Copy link
Contributor

Description

  • Created ItemExtendedCost.dbc (itemextendedcost_dbc)
  • Updated npc_vendor#extendedcost to have proper link to the newitemextendedcost_dbc
  • Created ItemPurchaseGroup.dbc (itempurchasegroup_dbc)

Related Issue

Not aware

@pangolp new changes to the EN files

| Field | Type | Attributes | Key | Null | Default | Extra | Comment |
| --------------------------------- | ------- | ---------- | --- | ---- | ------- | ----- | ------- |
| [ID](#id) | INT | UNSIGNED | PRI | NO | 0 |
| [ItemID_1](#itemid_1) | INT | UNSIGNED | | NO | 0 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

samne as other pr

@TheSCREWEDSoftware
Copy link
Contributor Author

Corrected

@TheSCREWEDSoftware
Copy link
Contributor Author

Ready to be reviewed.

@Helias Helias requested a review from Kitzunu November 19, 2024 17:38

ID that's used in [ItemPurchaseGroup.dbc](itempurchasegroup.dbc#id). <br>All entries use "0". No more information

### DBC File Content
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 146 to 154
<details>

<summary>Click to see the content </summary>

| ID | ItemID_1 | ItemID_2 | ItemID_3 | ItemID_4 | ItemID_5 | ItemID_6 | ItemID_7 | ItemID_8 | Name_Lang_enUS | Name_Lang_enGB | Name_Lang_koKR | Name_Lang_frFR | Name_Lang_deDE | Name_Lang_enCN | Name_Lang_zhCN | Name_Lang_enTW | Name_Lang_zhTW | Name_Lang_esES | Name_Lang_esMX | Name_Lang_ruRU | Name_Lang_ptPT | Name_Lang_ptBR | Name_Lang_itIT | Name_Lang_Unk | Name_Lang_Mask |
| --- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | -------------------------------- | -------------- | -------------- | -------------- | -------------- | -------------- | -------------- | -------------- | -------------- | -------------- | -------------- | -------------- | -------------- | -------------- | -------------- | ------------- | -------------- |
| 1 | 34529 | 34530 | 33006 | 0 | 0 | 0 | 0 | 0 | Vengeful Gladiator Ranged Weapon | | | | | | | | | | | | | | | | 16712190 |

</details>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Kitzunu Kitzunu merged commit f053ba3 into azerothcore:master Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants