-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vdc manage host modify #758
base: develop
Are you sure you want to change the base?
Conversation
✅ 50be26c success - wakame-ci/rspec |
✅ 50be26c success - wakame-ci/cli/vdc-manage |
❌ 50be26c failure - wakame-ci/cli/backup-cleaner |
Looks like the CI is still having trouble with its rbenv installation.
|
✅ 50be26c success - wakame-ci/cli/backup-cleaner |
✅ 50be26c success - wakame-ci/rspec |
✅ 50be26c success - wakame-ci/cli/vdc-manage |
✅ 50be26c success - wakame-ci/cli/backup-cleaner |
✅ 50be26c success - wakame-ci/rpmbuild |
✅ 50be26c success - wakame-ci/yumrepo/to-dropbox |
✅ 50be26c success - wakame-ci/yumrepo/to-s3 |
❌ 50be26c failure - wakame-ci/dummy.smoke |
❌ 50be26c failure - wakame-ci/kvm.smoke |
❌ 50be26c failure - wakame-ci/vz.smoke |
❌ 50be26c failure - wakame-ci/kvm.smoke.lb |
❌ 50be26c failure - wakame-ci/lxc.smoke.allowed-failure |
✅ 50be26c success - wakame-ci/rspec |
✅ 50be26c success - wakame-ci/cli/vdc-manage |
✅ 50be26c success - wakame-ci/cli/backup-cleaner |
✅ 50be26c success - wakame-ci/rpmbuild |
✅ 50be26c success - wakame-ci/yumrepo/to-dropbox |
✅ 50be26c success - wakame-ci/yumrepo/to-s3 |
✅ 50be26c success - wakame-ci/dummy.smoke |
✅ 50be26c success - wakame-ci/kvm.smoke.lb |
✅ 50be26c success - wakame-ci/kvm.smoke |
❌ 50be26c failure - wakame-ci/lxc.smoke.allowed-failure |
✅ 50be26c success - wakame-ci/vz.smoke |
Fixes #757
Whatever we're using (activesupport?) is smart enough to translate symbols to strings when accessing a hash but doesn't do the same for the
has_key?
method. We also weren't validating the hypervisor in the model class.