Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements CMAKE_OSX_ARCHITECTURES / codec class subclassing / AP4_FragmentSampleTable #977

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CastagnaIT
Copy link

@CastagnaIT CastagnaIT commented Aug 24, 2024

i choosen propose to send some less invasive changes from our custom bento4 in the hoping will be reviewed cc @barbibulle

commit 1:
CMAKE_OSX_ARCHITECTURES has been hardcoded, this lead to problems when you dont need to change it, at least on our build system dont need it, and this cause build failures.

my solution proposal is allow use of new bool: USE_DEFAULT_OSX_ARCHITECTURES
to allow to avoid set the default values
example: -DUSE_DEFAULT_OSX_ARCHITECTURES=OFF
the previous behaviour is kept without changes, but allow to disable it
fix #945

commit 2:
as title implement GetSampleIndexForTimeStamp/GetNearestSyncSampleIndex methods

commit 3:
allow codec audio parsers classes to be inherited, and that subclasses can access to private data/methods

CastagnaIT and others added 3 commits August 24, 2024 16:02
Set -DUSE_DEFAULT_OSX_ARCHITECTURES=OFF to avoid set by default
CMAKE_OSX_ARCHITECTURES for arm64, x86_64 architectures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build problem with CMAKE_OSX_ARCHITECTURES var
3 participants