Some improvements CMAKE_OSX_ARCHITECTURES / codec class subclassing / AP4_FragmentSampleTable #977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i choosen propose to send some less invasive changes from our custom bento4 in the hoping will be reviewed cc @barbibulle
commit 1:
CMAKE_OSX_ARCHITECTURES
has been hardcoded, this lead to problems when you dont need to change it, at least on our build system dont need it, and this cause build failures.my solution proposal is allow use of new bool:
USE_DEFAULT_OSX_ARCHITECTURES
to allow to avoid set the default values
example:
-DUSE_DEFAULT_OSX_ARCHITECTURES=OFF
the previous behaviour is kept without changes, but allow to disable it
fix #945
commit 2:
as title implement GetSampleIndexForTimeStamp/GetNearestSyncSampleIndex methods
commit 3:
allow codec audio parsers classes to be inherited, and that subclasses can access to private data/methods