Added tool mp4ls to list the "atom path" for each atom. #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tools such as mp4extract and mp4edit require an atom_path, but it can be tricky to identify this path given only the atom name. This tool will walk the atom heirarchy and list the full path to each atom it finds.
lfaureyt
reviewed
Apr 25, 2022
| if (parent != NULL){ | ||
| AP4_List<AP4_Atom>& children = parent->GetChildren(); | ||
| AP4_Cardinal n_children = children.ItemCount(); | ||
| for (int i=0; i<n_children; ++i){ |
There was a problem hiding this comment.
Suggested change
| for (int i=0; i<n_children; ++i){ | |
| for (unsigned i=0; i<n_children; ++i){ |
using an int as loop index triggers a signed/unsigned comparison warning at compile time
lfaureyt
reviewed
Apr 25, 2022
| AP4_List<AP4_Atom>& children = top_level.GetChildren(); | ||
| AP4_Cardinal n_children = children.ItemCount(); | ||
| std::string path; | ||
| for (int i=0; i<n_children; ++i){ |
There was a problem hiding this comment.
Suggested change
| for (int i=0; i<n_children; ++i){ | |
| for (unsigned i=0; i<n_children; ++i){ |
using an int as loop index triggers a signed/unsigned comparison warning at compile time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this sort of thing would be welcome in the upstream library, but I wrote a small tool to help me find the full path to each atom within the quicktime.
Tools such as mp4extract and mp4edit require an atom_path, but it can be tricky to identify this path given only the atom name.
This tool will walk the atom heirarchy and list the full path to each atom it finds.