Fix for onTestComplete #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…callback argument.
…tions. - identation is 4 spaces (I'm not sure about this, as half of the other functions use 2 spaces, the other half 4 spaces. In the end I have picked the 4 spaces.) - space before the functions' opening braces - single quotes
…ation into a promise. Error conversion is moved into a central location.
…main advantage is that the control flow has become much simpler, errors from multiple sources can be handled at a single point (the grunt task's entry point). Errors caused by too big test results are correctly reported (axemclion#123). Added new grunt tasks for testing test failures and too big test results.
…efined, a boolean, or a promise. Added new tests.
|
Closing this PR. I will create a new one which follows the coding style in #127. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #116. The onTestComplete callback can return undefined, a boolean or a promise.
Also added error checking and reporting for #123