Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anomaly RM#87532:Error on 'Default account' emptying in email accounts #13732

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Anomaly RM#87532:Error on 'Default account' emptying in email accounts #13732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...r-base/src/main/java/com/axelor/apps/base/service/message/MailAccountServiceBaseImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.axelor.apps.base.service.app.AppBaseService;
import com.axelor.apps.base.service.user.UserService;
import com.axelor.auth.db.User;
import com.axelor.common.StringUtils;
import com.axelor.i18n.I18n;
import com.axelor.message.db.EmailAccount;
import com.axelor.message.db.repo.EmailAccountRepository;
Expand Down Expand Up @@ -57,7 +58,7 @@ public void checkDefaultMailAccount(EmailAccount mailAccount) {
AppBase appBase = appBaseService.getAppBase();
if (appBase.getEmailAccountByUser() || appBase.getEmailAccountByCompany()) {
String query = this.mailAccountQuery(mailAccount);
if (!query.isEmpty()) {
if (!StringUtils.isEmpty(query)) {
if (appBase.getEmailAccountByUser()) {
query +=
" AND self.user"
Expand Down
3 changes: 3 additions & 0 deletions changelogs/unreleased/87532.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
title: "Email account: fixed NPE that occurred when setting 'Default account' to false."
module: axelor-base
Loading