feat: Valued express example #176
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry (from proper directory)
benjamin852
force-pushed
the
valued-express
branch
from
8bf3685
to
052d47c
Compare
StephenFluin
requested changes
Apr 15, 2024
| @@ -1,8 +1,9 @@ | |||
| //SPDX-License-Identifier: MIT | |||
| // //SPDX-License-Identifier: MIT | |||
There was a problem hiding this comment.
Typo? Double comment?
| @@ -0,0 +1,52 @@ | |||
| # Call Contract with Valued Express | |||
|
|
|||
| This is an example of sending an express transaction where the value is not a cross chain asset transfer using `callContractWithToken()`. Rather the value is in the `payload` of the transaction. Once the payload has been decoded and derived to a specific contract address that value can be transfered to the end receiver. | |||
There was a problem hiding this comment.
Reverse this to make the first sentence of the readme what it IS rather than what it ISN'T.
| # Call Contract with Valued Express | ||
|
|
||
| This is an example of sending an express transaction where the value is not a cross chain asset transfer using `callContractWithToken()`. Rather the value is in the `payload` of the transaction. Once the payload has been decoded and derived to a specific contract address that value can be transfered to the end receiver. | ||
|
|
There was a problem hiding this comment.
Can we add details about how it works at a high level? An overview? I hope we will also have corresponding updates in the docs?
|
|
||
| ```bash | ||
| npm run deploy evm/call-contract-with-valued-express local | ||
| npm run execute evm/call-contract-with-token local "Avalanche" "Fantom" 100 0xBa86A5719722B02a5D5e388999C25f3333c7A9fb |
There was a problem hiding this comment.
Is this right? Deploying a different contract that we execute?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added valued express executable tx. Also made a few (very minor) alterations to express token tx