feat: add nft and token linker contracts #144
Conversation
|
Hey, thanks for the PR 🙌🏻 Can you add a script to |
|
No problem @npty! And yes definitely, I will add those scripts once we wrap up with audits and releasing governance. |
| address gateway_, | ||
| address gasReceiver_, | ||
| address owner_ | ||
| ) ERC721('Axelar NFT Linker', 'ANL') AxelarExecutable(gateway_) Upgradable(owner_) { |
There was a problem hiding this comment.
| ) ERC721('Axelar NFT Linker', 'ANL') AxelarExecutable(gateway_) Upgradable(owner_) { | |
| ) ERC721('Axelar NFT Linker', 'ANL') AxelarExecutable(gateway_) Upgradable(msg.sender) { |
Just use msg.sender for these example contracts for simplicity and avoids breaking compatibility
|
|
||
| constructor(address implementationAddress, address owner, bytes memory setupParams) Proxy(implementationAddress, owner, setupParams) {} | ||
|
|
||
| // slither-disable-next-line dead-code |
There was a problem hiding this comment.
| // slither-disable-next-line dead-code |
add the same slither/solhint config to this repo?
There was a problem hiding this comment.
added solhint/slither configs to ignore these warnings
hardhat.config.js
Outdated
| @@ -1,3 +1,4 @@ | |||
| require("@nomiclabs/hardhat-ethers"); | |||
There was a problem hiding this comment.
why not import the toolbox here?
package.json
Outdated
| @@ -31,8 +31,10 @@ | |||
| "uuid": "^8.3.2" | |||
| }, | |||
| "devDependencies": { | |||
| "@nomiclabs/hardhat-ethers": "^2.2.3", | |||
There was a problem hiding this comment.
why not use the toolbox and remove this and gas reporter?
There was a problem hiding this comment.
I removed this, I tried to install toolbox and remove gas reporter but ran into a lot of dependency conflicts between the toolbox ethers and ethers in the dependencies. It seems like we are only using the gas reporter package from the toolbox so maybe importing the entire toolbox at the point is unnecessary?
package.json
Outdated
| @@ -31,8 +31,10 @@ | |||
| "uuid": "^8.3.2" | |||
| }, | |||
| "devDependencies": { | |||
| "@nomiclabs/hardhat-ethers": "^2.2.3", | |||
There was a problem hiding this comment.
now that tests were removed this shouldn't be needed?
hardhat.config.js
Outdated
| @@ -1,3 +1,4 @@ | |||
| require('@nomiclabs/hardhat-ethers'); | |||
PR to add NFT and Token linker contracts and tests to the examples repo.