Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sui): gh workflow for testing sui commands #339

Merged
merged 53 commits into from
Aug 29, 2024
Merged

chore(sui): gh workflow for testing sui commands #339

merged 53 commits into from
Aug 29, 2024

Conversation

npty
Copy link
Member

@npty npty commented Aug 19, 2024 •
edited
Loading

Description

AXE-4664

This PR adds the test workflow for sui which follows the same pattern as evm test workflow.

Todo

  • Fix error in rotate signers command
  • Fix error in execute incoming gmp contract call command
  • Add multisig tests

@npty npty changed the base branch from main to chore/cleanup-and-refactor August 19, 2024 09:31
Base automatically changed from chore/cleanup-and-refactor to main August 19, 2024 11:57
@npty npty force-pushed the chore/gh-workflow-for-sui-scripts branch from 90d27b1 to 9c11a86 Compare August 19, 2024 14:37
@npty npty self-assigned this Aug 20, 2024
npty
npty commented Aug 20, 2024
View reviewed changes
.github/workflows/test-sui.yaml Outdated Show resolved Hide resolved
.github/workflows/test-sui.yaml Outdated Show resolved Hide resolved
.github/workflows/test-sui.yaml Outdated Show resolved Hide resolved
milapsheth
milapsheth reviewed Aug 27, 2024
View reviewed changes
sui/gmp.js Show resolved Hide resolved
@npty npty changed the title chore: gh workflow for testing sui commands chore(sui): gh workflow for testing sui commands Aug 27, 2024
@npty npty mentioned this pull request Aug 28, 2024
Merged
milapsheth
milapsheth approved these changes Aug 29, 2024
View reviewed changes
.github/workflows/test-sui.yaml Show resolved Hide resolved
sui/utils/utils.js Show resolved Hide resolved
@npty npty enabled auto-merge (squash) August 29, 2024 13:40
@npty npty merged commit 31b2f67 into main Aug 29, 2024
5 checks passed
@npty npty deleted the chore/gh-workflow-for-sui-scripts branch August 29, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milapsheth milapsheth milapsheth approved these changes

@blockchainguyy blockchainguyy Awaiting requested review from blockchainguyy blockchainguyy is a code owner automatically assigned from axelarnetwork/chainops

@sdaveas sdaveas Awaiting requested review from sdaveas sdaveas is a code owner automatically assigned from axelarnetwork/chainops

Assignees

@npty npty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npty @milapsheth @blockchainguyy