feat: combine signatures into gateway batch #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanamiel
commented
Jan 24, 2024
re1ro
previously approved these changes
Jan 29, 2024
milapsheth
reviewed
Jan 31, 2024
evm/combine-signatures.js
Outdated
| for (const signatureJSON of sortedSignatures) { | ||
| const keyId = signatureJSON.key_id; | ||
| const msgHash = `0x${signatureJSON.msg_hash}`; | ||
| const pubKey = `0x${signatureJSON.pub_key}`; |
There was a problem hiding this comment.
verify that pub key matches the validator address in the file as well
There was a problem hiding this comment.
const validatorWeight = validatorWeights[validatorAddress.toLowerCase()];
if (!validatorWeight) {
printError('Validator does not belong to current epoch', validatorAddress);
return;
}
This check should ensure that all the validator public keys correspond to valid validators in the current epoch
blockchainguyy
requested changes
Feb 6, 2024
| kubectl exec -ti axelar-core-node-validator1-5b68db5c49-mf5q6 -n stagenet-validator1 -c vald -- sh | ||
| ``` | ||
|
|
||
| 7. Within the validator container, run the vald command from step 2 with the correct validator address. Validator addresses can be found by appending this endpoint `/axelar/multisig/v1beta1/key?key_id=[KEY_ID]` to the Axelar lcd url in the chains config file. Running this command should result in a JSON output containing the signature, similar to the example below: |
There was a problem hiding this comment.
@milapsheth is there a simpler way to identify the validator address of a container than looping through all the validators mentioned in the endpoint. this approach might not be viable on testnet or mainnet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for manually combining validator signatures into gateway batch as per AXE-2733