ci: add ability to upload wasm artefacts based on release hash #100
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
- Coverage 89.23% 89.20% -0.04%
==========================================
Files 43 43
Lines 2936 2936
==========================================
- Hits 2620 2619 -1
- Misses 316 317 +1 ☔ View full report in Codecov by Sentry. |
| cf-config-bucket-root-key: "${{ vars.CF_BUCKET_ROOT_KEY }}" | ||
|
|
||
| # we just want to upload to CF, do not run a github release | ||
| github-release: "false" |
There was a problem hiding this comment.
Not sure if github-release: "false" is the correct usage. Since we just want to upload to CF and don't want to run a github release, wouldn't it be something like cf-upload-wasm-to-bucket: "true"? This is somewhat confusing to me.
There was a problem hiding this comment.
The idea is that we always upload to CF but only sometimes want to do a github release. For regular releases, we do want to upload to github, so I just added the option to disable it and disabled it when we "release" based on the hash.
| github-release: | ||
| description: "Whether to upload the build as a github release" | ||
| required: false | ||
| default: "true" |
There was a problem hiding this comment.
Just wondering, why is it not required but defaulted to true?
There was a problem hiding this comment.
Mentioned it above, but, for regular releases we /do/ want to run a github release, so I had the default set to true so that I didn't have to change release.yaml.
closes AXE-6843
the new workflow is mostly adapted from
release.yaml