Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(minor-axelar-wasm-std-derive): derive macro into_event_derive #733

Merged
merged 7 commits into from
Dec 24, 2024
Merged

feat(minor-axelar-wasm-std-derive): derive macro into_event_derive #733

merged 7 commits into from
Dec 24, 2024
+90 −6

Conversation

fish-sammy
Copy link
Collaborator

@fish-sammy fish-sammy commented Dec 20, 2024 •
edited
Loading

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

@fish-sammy fish-sammy force-pushed the refactor/derive-into_event_derive branch from b3cfe09 to e4ddfb2 Compare December 20, 2024 23:48
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 93.65%. Comparing base (fbbb8d5) to head (93147b9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/axelar-wasm-std-derive/src/lib.rs 0.00% 28 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
- Coverage   93.73%   93.65%   -0.09%     
==========================================
  Files         220      220              
  Lines       35646    35674      +28     
==========================================
- Hits        33412    33409       -3     
- Misses       2234     2265      +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fish-sammy fish-sammy force-pushed the refactor/derive-into_event_derive branch from f5f2931 to 04eed38 Compare December 21, 2024 04:46
@fish-sammy fish-sammy marked this pull request as ready for review December 21, 2024 04:46
@fish-sammy fish-sammy requested a review from a team as a code owner December 21, 2024 04:46
@fish-sammy fish-sammy force-pushed the refactor/derive-into_event_derive branch from 9acd7c6 to a90dce9 Compare December 21, 2024 04:53
cgorenflo
cgorenflo approved these changes Dec 24, 2024
View reviewed changes
packages/axelar-wasm-std-derive/src/lib.rs Outdated Show resolved Hide resolved
packages/axelar-wasm-std-derive/src/lib.rs Show resolved Hide resolved
@fish-sammy fish-sammy merged commit 7240b50 into main Dec 24, 2024
7 of 8 checks passed
@fish-sammy fish-sammy deleted the refactor/derive-into_event_derive branch December 24, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgorenflo cgorenflo cgorenflo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fish-sammy @cgorenflo