Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(minor-ampd): separate generic public key for multisig signing and cosmos public key for tx signing #730

Merged
merged 5 commits into from
Dec 23, 2024
Merged

refactor(minor-ampd): separate generic public key for multisig signing and cosmos public key for tx signing #730

merged 5 commits into from
Dec 23, 2024

Conversation

fish-sammy
Copy link
Collaborator

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

@fish-sammy fish-sammy force-pushed the refactor/seperate-ampd-public-key-and-cosmos-public-key branch from fe98cb7 to 690f662 Compare December 17, 2024 20:03
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.67033% with 37 lines in your changes missing coverage. Please review.

Project coverage is 93.73%. Comparing base (5c276fa) to head (fb33c90).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
ampd/src/types/key.rs 81.91% 17 Missing ⚠️
ampd/src/tofnd/grpc.rs 0.00% 12 Missing ⚠️
ampd/src/commands/mod.rs 0.00% 6 Missing ⚠️
ampd/src/commands/register_public_key.rs 0.00% 1 Missing ⚠️
ampd/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
+ Coverage   93.43%   93.73%   +0.29%     
==========================================
  Files         234      220      -14     
  Lines       34891    35646     +755     
==========================================
+ Hits        32601    33412     +811     
+ Misses       2290     2234      -56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fish-sammy fish-sammy marked this pull request as ready for review December 17, 2024 21:44
@fish-sammy fish-sammy requested a review from a team as a code owner December 17, 2024 21:44
@fish-sammy fish-sammy changed the title refactor(ampd): separate generic public key for multisig signing and cosmos public key for tx signing refactor(minor-ampd): separate generic public key for multisig signing and cosmos public key for tx signing Dec 17, 2024
@fish-sammy fish-sammy force-pushed the refactor/seperate-ampd-public-key-and-cosmos-public-key branch from 958fc09 to 9c5ff42 Compare December 17, 2024 21:48
@fish-sammy fish-sammy force-pushed the refactor/seperate-ampd-public-key-and-cosmos-public-key branch from 9c5ff42 to ee519df Compare December 17, 2024 21:53
cgorenflo
cgorenflo reviewed Dec 20, 2024
View reviewed changes
ampd/src/tofnd/grpc.rs Show resolved Hide resolved
ampd/src/types/key.rs Outdated Show resolved Hide resolved
ampd/src/types/key.rs Show resolved Hide resolved
ampd/src/types/key.rs Show resolved Hide resolved
ampd/src/types/key.rs Outdated Show resolved Hide resolved
ampd/src/types/key.rs Show resolved Hide resolved
ampd/src/types/key.rs Show resolved Hide resolved
@fish-sammy fish-sammy merged commit fbbb8d5 into main Dec 23, 2024
7 of 8 checks passed
@fish-sammy fish-sammy deleted the refactor/seperate-ampd-public-key-and-cosmos-public-key branch December 23, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgorenflo cgorenflo cgorenflo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fish-sammy @cgorenflo