-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ampd): add Stacks handlers with verify logic for contract deployments #728
Open
raress96
wants to merge
30
commits into
axelarnetwork:main
Choose a base branch
from
Trust-Machines:stacks_ampd_v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(ampd): custom ITS logic for Stacks
… contract deployment by any contract on Stacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Besides the normal
stacks_verify_msg
andstacks_verify_verifier_set
handlers, we needed to add custom logic for Stacks in order to support verifying contract deploymentsOn Stacks, a smart contract can NOT deploy another smart contract, only EOA can deploy contracts. Stacks also doesn't have native assets, each token needs to be a smart contract. For security reasons, the Relayer will need to deploy the code for some ITS specific contracts, and the Axelar Validators will be used to verify the contract code. This code verification is generic, and can be used by any contract on Stacks.
payload
we find a tupleverify-contract
with the fieldsreference-address
&contract-address
reference-address
and compares it to the cod atcontract-address