FDP fixes #1790
Closed
FDP fixes #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current way of initilization limits ruhs from 0 to 127. Although fio supports a maximum of 128 ruhs, for the files supporting more the 128 placement ids user has the flexibility of specifying any 128 placement id index at a time. This commit updates the way we fetch ruhs. We now fetch the ruhs info in two steps. The first step only gets us the number of ruhs from the ioengine. This is used by fdp backend to allocate the correct buffer size for the second step, where we fetch the actual ruhs info. Signed-off-by: Ankit Kumar <[email protected]>
Use calloc instead of scalloc as ruhs buffer allocation is temporary. Remove the restriction on maximum number of ruhs, fetch and fill the ruhs buffer as requested by fdp backend. Signed-off-by: Ankit Kumar <[email protected]>
Remove the restriction on maximum number of ruhs, fetch and fill the ruhs buffer as requested by fdp backend. Signed-off-by: Ankit Kumar <[email protected]>
|
I applied the patches instead of merging the PR because I slightly edited the commit message for this first patch. https://git.kernel.dk/cgit/fio/commit/?id=56d12245953b4ae147784db2e77b1609197df4a0 |
|
I will take a closer look but I think this change will allow us to get rid of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way of fdp ruhs initialization limited it to a maximum of 128 ruhs descriptors. Fio allows a total of 128 placement id
indices at a time, but for devices supporting more the 128 ruhs, users should have the ability to pass any 128 placement id index / indices (0 to max number of ruhs - 1). This series fixes that.