Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples with Lightning integration, AWS credentials and S3 Express One Zone integration. #206

Merged
merged 3 commits into from
May 1, 2024

Conversation

dnanuti
Copy link
Contributor

@dnanuti dnanuti commented Apr 30, 2024

Description

  • Update the examples in the Jupyter notebook to include: Lightning integration, AWS credentials examples, and S3 Express One Zone integration.
  • Use the optional S3ClientConfig for public bucket access.
  • The updated notebook is visible here.

Additional context

  • Integration tests were failing unrelated to these changes, due to:

E ImportError: cannot import name 'DILL_AVAILABLE' from 'torch.utils.data.datapipes.utils.common' (/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/torch/utils/data/datapipes/utils/common.py)

A failed run example can be found here.
This failure is related to this open issue on PyTorch: pytorch/data#1244
Updating pyproject.toml files to restrict torch version to be different than 2.3.0 resolved this:

    #TODO: Remove torch != 2.3.0 restriction when https://github.com/pytorch/data/issues/1244 is fixed
    "torch >= 2.0.1, != 2.3.0",
  • I have updated the CHANGELOG or README if appropriate

Related items

Testing

  • Ran locally

By submitting this pull request, I confirm that my contribution is made under the terms of BSD 3-Clause License and I agree to the terms of the LICENSE.

@dnanuti dnanuti temporarily deployed to integration-tests April 30, 2024 13:53 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 30, 2024 13:53 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 30, 2024 13:53 — with GitHub Actions Inactive
IsaevIlya
IsaevIlya previously approved these changes Apr 30, 2024
@muddyfish
Copy link
Contributor

Can we change this line so it's on multiple?

dataset = s3torchconnector.S3IterableDataset.from_prefix(IMAGES_URI, region=REGION, transform=load_image, s3client_config=config)

It currently goes off the end of the code preview on my window and it doesn't seem to support scrolling left/right

@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:38 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:38 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:39 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:39 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:39 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:39 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:39 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:39 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:39 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:39 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:39 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:39 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:39 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:39 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:39 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:39 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:39 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:39 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:39 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests May 1, 2024 10:39 — with GitHub Actions Inactive
@dnanuti dnanuti merged commit 91b36e9 into main May 1, 2024
67 checks passed
@dnanuti dnanuti deleted the feature/update-examples branch May 1, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants