Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing documentation for fuser Mount structs #1105

Merged

Conversation

dannycjones
Copy link
Contributor

@dannycjones dannycjones commented Nov 6, 2024

Description of change

Our fuser fork emits a lot of warnings during builds, impacting our pull requests. This change addresses missing documentation on one struct in fuser (which was introduced by our change in #1098).

This change is a good candidate to be contributed to upstream. Once contributed, this commit can be removed.

Relevant issues: N/A

Does this change impact existing behavior?

No.

Does this change need a changelog entry in any of the crates?

No.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@dannycjones dannycjones marked this pull request as ready for review November 6, 2024 17:17
@dannycjones dannycjones changed the title Add missing documentation for mnt::fuse2::Mount Add missing documentation for fuser Mount structs Nov 6, 2024
Copy link
Contributor

@passaro passaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This was really a consequence of #1098, we'll need to merge them if we want to try and upstream.

@dannycjones dannycjones merged commit 06212fc into awslabs:fuser/fork Nov 6, 2024
8 of 9 checks passed
@dannycjones dannycjones deleted the fuser/add-missing-documentation branch November 6, 2024 17:45
dannycjones added a commit that referenced this pull request Nov 12, 2024
Our fuser fork emits a lot of warnings during builds, impacting our pull
requests. This change addresses missing documentation on one struct in
fuser (which was introduced by our change in
#1098).

This change is a good candidate to be contributed to upstream. Once
contributed, this commit can be removed.

Relevant issues: N/A

No.

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and I agree to the terms of
the [Developer Certificate of Origin
(DCO)](https://developercertificate.org/).

---------

Signed-off-by: Daniel Carl Jones <[email protected]>
dannycjones added a commit that referenced this pull request Nov 12, 2024
Our fuser fork emits a lot of warnings during builds, impacting our pull
requests. This change addresses missing documentation on one struct in
fuser (which was introduced by our change in
#1098).

This change is a good candidate to be contributed to upstream. Once
contributed, this commit can be removed.

Relevant issues: N/A

No.

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and I agree to the terms of
the [Developer Certificate of Origin
(DCO)](https://developercertificate.org/).

---------

Signed-off-by: Daniel Carl Jones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants