Preserve exact-match cardinality when binning data for plots #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If binning() is passed a vector already exactly matching its target cardinality, it now returns the values of the vector as-is.
athewsey
force-pushed
the
fix/plot-binning
branch
from
5d1b703 to
6e30c10
Compare
Specify on LatencyHeatmap plots whether labelled I/O token values are binned ranges or exact counts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #5
Description of changes:
Update
binning()to preserve input vector values as-is, in case the cardinality of the data already exactly matches the requested number of bins.Update
plot_heatmap()to indicate whether the displayed input & output token counts are binned ranges or exact values.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.