Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pyproject.toml #3075

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

Move to pyproject.toml #3075

wants to merge 6 commits into from

Conversation

lostella
Copy link
Contributor

@lostella lostella commented Dec 6, 2023

Description of changes: the objective is to move all of the project config and metadata from setup.py and setup.cfg to pyproject.toml

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@lostella lostella requested a review from abdulfatir December 6, 2023 09:56
@lostella
Copy link
Contributor Author

lostella commented Dec 6, 2023

      ValueError: invalid pyproject.toml config: `project`.
      configuration error: `project` must contain ['version'] properties

We're currently handling the __version__ in python with some automagic-git-tag-related trick. Having the version written down in pyproject.toml would require that we update it manually when tagging I guess?

@abdulfatir
Copy link
Contributor

@lostella lostella changed the title Add project details to pyproject Move to pyproject.toml Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants