Several performance optimizations #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nload throughput. Most of this is by switching to release build, but other optimizations got a combined ~1.5x increase too, as tested on m6i.8xlarge instances with EBS VPC Endpoint.
…ocks; more thread tweaking.
… m6i.16xlarge instance with EBS VPC Endpoint.
|
Thanks for this, @kdavyd! We're giving it a look! |
zmrow
reviewed
Sep 14, 2021
| const SHA256_ALGORITHM: &str = "SHA256"; | ||
| const DISABLE_SHA: bool = true; |
There was a problem hiding this comment.
We probably don't want to turn off the SHA hash checking by default. I could maybe see providing users a flag to turn this off, but a constant isn't really configurable, and isn't currently documented or particularly discoverable.
| @@ -355,7 +358,9 @@ impl SnapshotDownloader { | |||
| .await | |||
| .context(error::WriteFileBytes { path, count })?; | |||
|
|
|||
| f.flush().await.context(error::FlushFile { path })?; | |||
| if !DISABLE_SHA { | |||
There was a problem hiding this comment.
The formatting looks a bit off here - can we make sure to run all the code through rustfmt?
| type Result<T> = std::result::Result<T, error::Error>; | ||
|
|
||
| #[tokio::main] | ||
| #[tokio::main(flavor = "multi_thread", worker_threads = 512)] |
There was a problem hiding this comment.
Curious how you calculated or determined this number!
zmrow
reviewed
Sep 14, 2021
| rusoto-native-tls = ["rusoto_core/native-tls", "rusoto_ebs/native-tls", "rusoto_ec2/native-tls"] | ||
| rusoto-rustls = ["rusoto_core/rustls", "rusoto_ebs/rustls", "rusoto_ec2/rustls"] | ||
|
|
||
| [dependencies] | ||
| argh = "0.1.3" | ||
| tokio = { version = "~1.8", features = ["fs", "io-util", "time"] } # LTS | ||
| tokio = { version = "~1.11", features = ["fs", "io-util", "time"] } # LTS |
There was a problem hiding this comment.
Also, we're hoping to stay on tokio 1.8 as it's an LTS release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About 4.5x overall increase in download throughput. Most of this is by switching to release build, but other optimizations got a combined ~1.5x increase too, as tested on m6i.8xlarge instances with EBS VPC Endpoint.
Focusing on download performance only. Best performance I got is around 230MB/sec on a fully allocated 100GB snapshot.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.