support checking for object modified during download #82
Conversation
|
|
||
| /// Test the if_match header was added correctly based on the response from server. | ||
| #[tokio::test] | ||
| async fn test_download_if_match() { |
There was a problem hiding this comment.
What's the expected behavior if the tag has changed? Can we add a test for it?
There was a problem hiding this comment.
I added a test for mock the object change, but the error will just be the service error from S3 that complains about if-match precondition didn't work.
In aws-c-s3, we override this error to our customized error code to inform it's because the object changed during download. But, in here, we are not overriding any service error, right?
There was a problem hiding this comment.
We haven't yet I think this is fine for now though unless you see an ergonomic reason to change it for users.
There was a problem hiding this comment.
The reason we override it for aws-c-s3 mostly because the if-match header was added by the client under the hood, so, it may be confusing to user for the if-match precondition failure.
But, not a big deal for now.
| /// assertions directly on the captured requests. | ||
| /// 2. First request for discovery, succeed with etag | ||
| /// 3. Followed requests fail to mock the object changed during download. | ||
| fn mock_object_modified_connector(data: &Bytes, part_size: usize) -> StaticReplayClient { |
There was a problem hiding this comment.
I think we should move this to the actual test, unless it will be used in multiple tests.
TingDaoK
changed the title
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.