config loader #53
Merged
config loader #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waahm7
approved these changes
Sep 24, 2024
ysaito1001
approved these changes
Sep 27, 2024
aajtodd
force-pushed
the
atodd/loader
branch
from
594628a to
a4d9183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
closes #15
related: #20
Description of changes:
ConfigLoaderandfrom_env()method that can be used to set the defaults for the transfer manager client. This is similar to howaws-configworks today (though we have no intermediateSdkConfigto deal with). This would also be our future point of extension to auto detect environment (e.g. EC2 instance type, etc) if we wanted.aws-smithy-experimentalhttprelated things into it's own moduleBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.