Fix Rasberry Pi stream test failures. (#293)

### ISSUE Bizarre behavior on 32bit Raspberry Pi OS when aws_input_stream_seek() was called, due to aws-c libraries not being compiled with Large Files Support (LFS), which led to confusion over the size of off_t, which led to stack corruption when functions took arguments of this type. ### CHANGES This incorporates fixes from awslabs/aws-c-common#808 and awslabs/aws-c-io#386. int64_t is now used for offsets instead of off_t/aws_off_t.
awslabs · Jun 2, 2021 · c058989 · c058989
1 parent 2c7b49f
commit c058989
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/crt/aws-c-common b/crt/aws-c-common
diff --git a/source/io.c b/source/io.c
@@ -650,7 +650,7 @@ static void s_aws_input_stream_py_destroy(struct aws_input_stream *stream) {
 
 static int s_aws_input_stream_py_seek(
     struct aws_input_stream *stream,
-    aws_off_t offset,
+    int64_t offset,
     enum aws_stream_seek_basis basis) {
 
     struct aws_input_stream_py_impl *impl = stream->impl;
@@ -664,7 +664,7 @@ static int s_aws_input_stream_py_seek(
         return AWS_OP_ERR; /* Python has shut down. Nothing matters anymore, but don't crash */
     }
 
-    method_result = PyObject_CallMethod(impl->self_proxy, "_seek", "(li)", offset, basis);
+    method_result = PyObject_CallMethod(impl->self_proxy, "_seek", "(Li)", offset, basis);
     if (!method_result) {
         aws_result = aws_py_raise_error();
         goto done;

diff --git a/source/s3_meta_request.c b/source/s3_meta_request.c
@@ -372,7 +372,7 @@ static int s_aws_input_stream_file_read(struct aws_input_stream *stream, struct
 }
 static int s_aws_input_stream_file_seek(
     struct aws_input_stream *stream,
-    aws_off_t offset,
+    int64_t offset,
     enum aws_stream_seek_basis basis) {
     struct aws_input_py_stream_file_impl *impl = stream->impl;
     return aws_input_stream_seek(impl->actual_stream, offset, basis);
+4 −1		.github/workflows/ci.yml
+1 −0		.github/workflows/clang-format.yml
+53 −2		cmake/AwsCFlags.cmake
+1 −0		include/aws/common/config.h.in
+95 −0		include/aws/common/promise.h
+3 −3		include/aws/common/ring_buffer.inl
+3 −10		include/aws/common/stdint.h
+11 −5		source/byte_buf.c
+115 −0		source/promise.c
+7 −6		source/ring_buffer.c
+6 −0		tests/CMakeLists.txt
+180 −0		tests/promise_test.c
+1 −0		verification/cbmc/.gitignore
+5 −1		verification/cbmc/proofs/aws_byte_cursor_advance/aws_byte_cursor_advance_harness.c
+5 −1		verification/cbmc/proofs/aws_byte_cursor_advance_nospec/aws_byte_cursor_advance_nospec_harness.c
+5 −1		verification/cbmc/proofs/aws_byte_cursor_read/aws_byte_cursor_read_harness.c
+5 −1		verification/cbmc/proofs/aws_byte_cursor_read_and_fill_buffer/aws_byte_cursor_read_and_fill_buffer_harness.c
+1 −0		verification/cbmc/proofs/aws_hash_table_clean_up/aws_hash_table_clean_up_harness.c
+3 −2		verification/cbmc/proofs/aws_ring_buffer_init/Makefile
+13 −8		verification/cbmc/proofs/aws_ring_buffer_init/aws_ring_buffer_init_harness.c
+9 −3		verification/cbmc/sources/make_common_data_structures.c
+1 −1		verification/cbmc/templates