Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android CI #839

Merged
merged 13 commits into from
Nov 1, 2024
Merged

Fix Android CI #839

merged 13 commits into from
Nov 1, 2024

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Oct 31, 2024

Issue:
The Android CI started failing due to:

Daemon will be stopped at the end of the build after running out of JVM memory
> Task :android:crt:lintAnalyzeDebug FAILED

This has been a recurring issue since we updated a bunch of build stuff as part of updating CMake #837.

Description of changes:

Manually set -Xmx (max heap size) to something huge (tested 2g and that works, but why not go bigger) via the cmdline when invoking gradle in CI. Only in CI, gradle daemon runs out of memory during "lintAnalyzeDebug" task, unless you specify it this way. You'd think that Java's default of 25% RAM (ubuntu24 runner has 12g, so max 4g) would be sufficient, but no. You'd think setting -Xmx via gradle.properties would help, but no.

Also, make it so a new commit cancels any old in-progress builds. It's a waste of energy to continue these builds, some of which take a looooooong time.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@TingDaoK TingDaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@graebm graebm merged commit d76fdba into main Nov 1, 2024
50 checks passed
@graebm graebm deleted the spooky-lint branch November 1, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants