[s3_client]: retry on failed TLS negotiation #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed TLS negotiation happens more often than expected, and it is a recoverable error. Hence retry it. Resolves awslabs#477.
|
We just added this code, to not-retry-on-TLS-failure a year ago, see: #316 Sadly, the PR doesn't describe the customer issue that led to this change (the PR author is out this week, so can't ask him). But if memory serves, someone was unhappy with how long it took genuine TLS failures to surface, given that they used to be retried several times, with backoff time between each retry. I'm closing this PR, but I'll make further comments on the issue page... |
|
@graebm - can you do something that genuine TLS failures are distinguished from retryable ones? |
graebm
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed TLS negotiation happens more often than expected, and it is a recoverable error. Hence retry it.
Resolves #477.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.