Fix a bunch of places we forget to aws_raise_error() (#405)

awslabs · Feb 13, 2024 · 593c2ab · 593c2ab
1 parent 63da70e
commit 593c2ab
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -6,7 +6,7 @@ on:
       - 'main'
 
 env:
-  BUILDER_VERSION: v0.9.48
+  BUILDER_VERSION: v0.9.55
   BUILDER_SOURCE: releases
   BUILDER_HOST: https://d19elf31gohf1l.cloudfront.net
   PACKAGE_NAME: aws-c-s3

diff --git a/.github/workflows/codecov.yml b/.github/workflows/codecov.yml
@@ -5,7 +5,7 @@ on:
 
 
 env:
-  BUILDER_VERSION: v0.9.29
+  BUILDER_VERSION: v0.9.55
   BUILDER_SOURCE: releases
   BUILDER_HOST: https://d19elf31gohf1l.cloudfront.net
   PACKAGE_NAME: aws-c-s3

diff --git a/source/s3_checksums.c b/source/s3_checksums.c
@@ -264,7 +264,7 @@ int aws_checksum_compute(
         case AWS_SCA_CRC32C:
             return aws_checksum_compute_fn(allocator, input, output, aws_crc32c_checksum_new, truncate_to);
         default:
-            return AWS_OP_ERR;
+            return aws_raise_error(AWS_ERROR_INVALID_ARGUMENT);
     }
 }
 

diff --git a/tests/s3_data_plane_tests.c b/tests/s3_data_plane_tests.c
@@ -6919,7 +6919,7 @@ static int s_test_s3_put_pause_resume_happy_path(struct aws_allocator *allocator
     aws_input_stream_destroy(resume_upload_stream);
     aws_s3_tester_clean_up(&tester);
 
-    return AWS_ERROR_SUCCESS;
+    return AWS_OP_SUCCESS;
 }
 
 AWS_TEST_CASE(test_s3_put_pause_resume_all_parts_done, s_test_s3_put_pause_resume_all_parts_done)
@@ -6998,7 +6998,7 @@ static int s_test_s3_put_pause_resume_all_parts_done(struct aws_allocator *alloc
     aws_input_stream_destroy(resume_upload_stream);
     aws_s3_tester_clean_up(&tester);
 
-    return AWS_ERROR_SUCCESS;
+    return AWS_OP_SUCCESS;
 }
 
 AWS_TEST_CASE(test_s3_put_pause_resume_invalid_resume_data, s_test_s3_put_pause_resume_invalid_resume_data)
@@ -7076,7 +7076,7 @@ static int s_test_s3_put_pause_resume_invalid_resume_data(struct aws_allocator *
     aws_input_stream_destroy(resume_upload_stream);
     aws_s3_tester_clean_up(&tester);
 
-    return AWS_ERROR_SUCCESS;
+    return AWS_OP_SUCCESS;
 }
 
 AWS_TEST_CASE(test_s3_put_pause_resume_invalid_resume_stream, s_test_s3_put_pause_resume_invalid_resume_stream)
@@ -7159,7 +7159,7 @@ static int s_test_s3_put_pause_resume_invalid_resume_stream(struct aws_allocator
     aws_input_stream_release(resume_upload_stream);
     aws_s3_tester_clean_up(&tester);
 
-    return AWS_ERROR_SUCCESS;
+    return AWS_OP_SUCCESS;
 }
 
 AWS_TEST_CASE(test_s3_put_pause_resume_invalid_content_length, s_test_s3_put_pause_resume_invalid_content_length)
@@ -7238,7 +7238,7 @@ static int s_test_s3_put_pause_resume_invalid_content_length(struct aws_allocato
     aws_input_stream_release(resume_upload_stream);
     aws_s3_tester_clean_up(&tester);
 
-    return AWS_ERROR_SUCCESS;
+    return AWS_OP_SUCCESS;
 }
 
 /* Most basic test of the upload_review_callback */