Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for GCC-13 on Ubuntu-18 #700

Merged
merged 25 commits into from
Dec 19, 2024
Merged

Fix CI for GCC-13 on Ubuntu-18 #700

merged 25 commits into from
Dec 19, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Dec 18, 2024

See Issue: llvm/llvm-project#59007. Although this issue has been fixed in LLVM, the fix will not probably propagate to older versions of Ubuntu and GCC-13.1.

Starting with GLIBC version 2.34, the dn_expand function, previously found in libresolv.so, was moved to libc.so. This function is used internally by the getaddrinfo() system call.

In our setup, we are using an Ubuntu 18 Docker image on a newer Ubuntu host. However, due to compatibility issues between newer libasan.so in GCC 13.1 and the older Ubuntu image, the linker does not link with libresolv.so. This results in crashes in getaddrinfo().

This problem does not occur on Ubuntu 22 and newer because GLIBC versions 2.34 and above include dn_expand in libc.so, eliminating the dependency on libresolv.so.

We can bypass this problem by linking with "resolv" manually until we bump our base Linux image to Ubuntu 22.

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.08%. Comparing base (b1d0202) to head (6b5995e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #700      +/-   ##
==========================================
- Coverage   80.10%   80.08%   -0.02%     
==========================================
  Files          29       29              
  Lines        6001     6001              
==========================================
- Hits         4807     4806       -1     
- Misses       1194     1195       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waahm7 waahm7 merged commit 2c6ef60 into main Dec 19, 2024
43 checks passed
@waahm7 waahm7 deleted the gcc-13 branch December 19, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants