Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tls1.3 win update #676

Draft
wants to merge 164 commits into
base: main
Choose a base branch
from
Draft

Tls1.3 win update #676

wants to merge 164 commits into from

Conversation

bretambrose
Copy link
Contributor

@bretambrose bretambrose commented Sep 25, 2024 •
edited by sfod
Loading

Support TLS 1.3 on Windows when mTLS is used.

Other changes:

  • Use persistent key container for RSA keys.
  • Implement local TLS server for tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

alfred2g added 30 commits June 13, 2024 10:28
@alfred2g
tls1.3 support
624fe50
@alfred2g
add version check
6c28ad0
@alfred2g
add version check
de09df2
@alfred2g
sync
5586e6a
@alfred2g
version info
c20a5dd
@alfred2g
crate acquire common section
4f50b77
@alfred2g
Split newer and older versions of windows
a5a3390
@alfred2g
more cleanups
9d7eec0
@alfred2g
Fix missing definitions sc_ctx
f8299fa
@alfred2g
typo
f49ae4a
@alfred2g
Fix dwflags
bcf5e8a
@alfred2g
Fix version number fetch
4625803
@alfred2g
separate credentials into common parameter
3f25df0
@alfred2g
remove duplicate status
cd61590
@alfred2g
fix some errors
ff9ba3b
@alfred2g
Add local schannel credential
ec1653b
@alfred2g
fix reference paCred
07f3959
@alfred2g
use common code for credentials
41e5652
@alfred2g
Remove comments
3bb3396
@alfred2g
Fix indentation
eee6ade
@alfred2g
Fix warnings
75db3db
@alfred2g
add logs
324ade1
@alfred2g
Fix warnings
e9871c6
@alfred2g
clang format
bf25cd2
@alfred2g
clang format
f5f8c3b
@alfred2g
Style: clang-format
92c9936
@alfred2g
enable protocol fields
4fa64c2
@alfred2g
clang format
6c8743f
@alfred2g
enable tls1.3
7469078
@alfred2g
Fix enabled protocols
228d45b
@sfod sfod marked this pull request as ready for review December 10, 2024 00:48
sbSteveK
sbSteveK reviewed Dec 12, 2024
View reviewed changes
tests/tls_handler_test.c Outdated Show resolved Hide resolved
sbSteveK
sbSteveK approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@sbSteveK sbSteveK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think we should probably make the change to status to be clearer about what's going on and what result is being checked. It doesn't appear like we'd run into a fall-through where the result of a previous status is being inappropriately checked but I'm not familiar enough with Windows TLS function to be certain. I'll leave that discretion up to you.

@sfod sfod marked this pull request as draft December 16, 2024 20:10
@sfod
Copy link
Contributor

sfod commented Dec 16, 2024

I converted this PR to draft, so it's not accidentally merged before it gets an approval from security

@jmklix jmklix mentioned this pull request Dec 16, 2024
Open
@jmklix jmklix linked an issue Dec 16, 2024 that may be closed by this pull request
Fail of the AcquireCredentialsHandleA for TLS 1.3 #609
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfod sfod sfod left review comments

@sbSteveK sbSteveK sbSteveK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail of the AcquireCredentialsHandleA for TLS 1.3
7 participants
@bretambrose @codecov-commenter @sfod @sbSteveK @alfred2g @xiazhvera @sfodagain